RE: [EXTERNAL] Re: [PATCH] bisect: fix replay of CRLF logs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2020-05-08 09:31-07:00, Junio C Hamano wrote:

>> I wonder if we can add a CR to IFS so that the parsing logic of each line
>> would not even see it?

> So I got curious and tried this; it seems to pass Christopher's test
> (corrected with Eric's suggestion).

> As the implementation changed, I ended up rewriting some parts of the log
> message originally proposed and here is what I tentatively queued.

This approach is much cleaner. Thank you, Eric, Junio, and Peff.

I can confirm 6c722cbe5a (bisect: allow CRLF line endings in "git bisect
replay" input, 2020-05-07) works on a CRLFed bisect log when I apply it to
git version 2.26.2.windows.1.

-- 
Christopher Warrington <chwarr@xxxxxxxxxxxxx>
Microsoft Corp.

(Apologies about the [EXTERNAL] in the subject. It gets added on the way in,
and if I remove it, the References: and In-Reply-To: headers get "helpfully"
stripped out.)




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux