On 5/7/2020 7:51 PM, Ramsay Jones wrote: > From: =?UTF-8?q?=C4=90o=C3=A0n=20Tr=E1=BA=A7n=20C=C3=B4ng=20Danh?= > <congdanhqx@xxxxxxxxx> > > * We need a `final_new_line` to make our source code as text file, per > POSIX and C specification. > * `bloom_filters` should be limited to interal linkage only > > Signed-off-by: Đoàn Trần Công Danh <congdanhqx@xxxxxxxxx> > Signed-off-by: Ramsay Jones <ramsay@xxxxxxxxxxxxxxxxxxxx> > --- > > Hi Junio, > > This patch by Danh seems to have slipped through the cracks, so I decided > to pass it along. The original version of this patch (which I don't seem > to be able to find) clashed with one of Jeff's series [1], because they > both fixed up a 'No newline at end of file' issue with test-bloom.c. > Also as Danh points out [2], the original patch didn't fix up the test > files. > > Anyway, this fixes up some 8 sparse warnings on 'master' and 'next': > > $ diff sp-out sp-out1 > 17d16 > < bloom.h:90:6: warning: no newline at end of file > 20,22d18 > < bloom.c:276:1: warning: no newline at end of file > < bloom.h:90:6: warning: no newline at end of file > < bloom.c:12:26: warning: symbol 'bloom_filters' was not declared. Should it be static? > 33d28 > < bloom.h:90:6: warning: no newline at end of file > 163d157 > < bloom.h:90:6: warning: no newline at end of file > 366,367d359 > < ./bloom.h:90:6: warning: no newline at end of file > < t/helper/test-bloom.c:6:30: warning: symbol 'settings' was not declared. Should it be static? > $ > > ... along with a further warning on 'pu', due to the 'ds/line-log-on-bloom' > branch adding another '#include "bloom.h"'. Thanks for being careful and making sure this gets in. The patch looks good to me. -Stolee
