Shourya Shukla <shouryashukla.oo@xxxxxxxxx> writes: > On 06/05 10:09, Christian Couder wrote: >> > + strbuf_addf(&config_name, "submodule.%s.url", path); >> > + >> > + config_set_in_gitmodules_file_gently(config_name.buf, newurl); >> > + sync_submodule(path, prefix, quiet ? OPT_QUIET : 0); >> > + >> > + strbuf_release(&config_name); >> >> Nit: it might be a bit simpler to define config_name as a "char *", >> and then use xstrfmt() and free() instead of strbuf_addf() and >> strbuf_release(). > > Apart from the simplicity purposes, does doing this aid in performance > in any way? strbuf.c::xstrfmt() uses strbuf.c::xstrvfmt() that formats into a temporary strbuf and returns the detached buffer as the result. Compare it with what strbuf.c::strbuf_addf() and you can draw a conclusion on your own ;-)
