On 5/6/2020 12:18 PM, Eric Sunshine wrote: > On Wed, May 6, 2020 at 5:44 AM Derrick Stolee via GitGitGadget > <gitgitgadget@xxxxxxxxx> wrote: >> diff --git a/t/t5319-multi-pack-index.sh b/t/t5319-multi-pack-index.sh >> @@ -538,6 +538,32 @@ test_expect_success 'repack with minimum size does not alter existing packs' ' >> +test_expect_success 'repack respects repack.packKeptObjects=false' ' >> + test_when_finished rm -f dup/.git/objects/pack/*keep && >> + ( >> + [...] >> + THIRD_SMALLEST_SIZE=$(test-tool path-utils file-size .git/objects/pack/*pack | sort -n | head -n 3 | tail -n 1) && >> + BATCH_SIZE=$(($THIRD_SMALLEST_SIZE + 1)) && > > Taking jk/arith-expansion-coding-guidelines[1] into consideration, > perhaps write this as: > > BATCH_SIZE=$((THIRD_SMALLEST_SIZE + 1)) && Thanks for pointing this out. This line is repeated in the test after this one. That should be fixed, too. Thanks, -Stolee
