On Wed, May 6, 2020 at 10:03 AM Abhishek Kumar <abhishekkumar8222@xxxxxxxxx> wrote: > As reported by Perrick [1], commit does not propagate quiet behavior to > gc if present. While we are at it, convert argv_gc_auto to struct argv_array. > > [1]: https://lore.kernel.org/git/20200506094327.GC31637@rillettes/ According to the source you cite, this sort of issue has come up before in a different context (git-fetch). Do we know if there are other commands which invoke git-gc which might also suffer the same issue? It would be nice for the commit message to say something about this... for instance, that git-commit is the final command which needs this fix or, if not, which additional commands are likely to need the same treatment. > Reported-by: Pierrick Gaudry <pierrick.gaudry@xxxxxxxx> > Signed-off-by: Abhishek Kumar <abhishekkumar8222@xxxxxxxxx>