On 5/6/2020 5:43 AM, Son Luong Ngoc via GitGitGadget wrote: > From: Son Luong Ngoc <sluongng@xxxxxxxxx> ... > - `repack.writeBitmaps` when `--batch-size=0` was NOT adopted here as it > requires `--all` to be passed onto `git pack-objects`, which is very > slow. I think it would be nice to have this in a future patch. Just my two cents here: the reachability bitmaps are really tied to the idea of a single pack right now. To create bitmaps, I would currently suggest using the 'git repack' builtin with the proper options. That command deletes the multi-pack-index, unfortunately, but it also produces a single pack and deletes the others (when creating bitmaps). You are right that the `--all` option required to pack-objects is not appropriate to add inside `git multi-pack-index repack` as that changes the pattern. It requires loading all reachable objects, even if they are not already in packs covered by the multi-pack-index. This at minimum violates expectations with the --batch-size argument. Integrating reachability bitmaps more closely with the multi-pack-index is certainly on our radar, but is a large endeavor. This new patch looks good to me. Thanks, -Stolee
