On Tue, May 05, 2020 at 08:01:29AM -0400, Derrick Stolee wrote:
> On 5/4/2020 9:13 PM, Taylor Blau wrote:
> > @@ -228,18 +240,25 @@ static int graph_write(int argc, const char **argv)
> > if (opts.stdin_commits) {
> > oidset_init(&commits, 0);
> > flags |= COMMIT_GRAPH_WRITE_CHECK_OIDS;
> > + if (opts.progress)
> > + progress = start_delayed_progress(
> > + _("Analyzing commits from stdin"), 0);
> The code functions as you intend and is an improvement. Similar to my
> earlier suggestion to use something like "Collecting referenced commits"
> for the --reachable case, perhaps this could be "Collecting commits from input"?
Yep, making these consistent with one another is a good thing to do,
thanks.
> Thanks,
> -Stolee
Thanks,
Taylor
