On Mon, May 04, 2020 at 02:05:16PM -0700, Junio C Hamano wrote: > Jeff King <peff@xxxxxxxx> writes: > > > Commit 9e468334b4 (ref-filter: fallback on alphabetical comparison, > > 2015-10-30) taught ref-filter's sort to fallback to comparing refnames. > > But it did it at the wrong level, overriding the comparison result for a > > single "--sort" key from the user, rather than after all sort keys have > > been exhausted. > > Good find. It does look like that the fallback was broken from the > very first version when it was introduced, as we did have multiple > keys support back in that version already. > > The fix looks good to me. Me too. Reviewed-by: Taylor Blau <me@xxxxxxxxxxxx> > Thanks. Thanks, Taylor
