On Mon, May 04, 2020 at 02:00:12PM -0700, Junio C Hamano wrote: > Jeff King <peff@xxxxxxxx> writes: > > > would sort the primary key (taggername) case-insensitively, but sort the > > refname case-sensitively. We have two options here: > > > > - teach callers to set ignore_case on the whole list > > > > - replace the ref_sorting list with a struct that contains both the > > list of sorting keys, as well as options that apply to _all_ > > keys > > > > I went with the first one here, as it gives more flexibility if we later > > want to let the users set the flag per-key (presumably through some > > special syntax when defining the key; for now it's all or nothing > > through --ignore-case). > > A good design decision I would fully support. I admit I had second thoughts when dealing with the "oops, we have to choose ignore_case from the first one" part of the second patch. But I think it works OK in practice, and I did like having a less invasive diff. :) -Peff
