On 2020-05-04 12:07:09-0400, Jeff King <peff@xxxxxxxx> wrote: > On Mon, May 04, 2020 at 08:37:38AM -0700, Junio C Hamano wrote: > > Subject: CodingGuidelines: drop arithmetic expansion advice to use "$x" > > The advice to use "$x" rather than "x" in arithmetric expansion was > working around a dash bug fixed in 0.5.4. Even Debian oldstable has > 0.5.7 these days. And in the meantime, we've added almost two dozen > instances of the "x" form which you can find with: > > git grep '$(([a-z]' > > and nobody seems to have complained. Let's declare this workaround > obsolete and simplify our style guide. > > Helped-by: Danh Doan <congdanhqx@xxxxxxxxx> > Signed-off-by: Jeff King <peff@xxxxxxxx> I see this patch hasn't been merged to pu yet. Please have my name as (if it's not too much trouble for you): Đoàn Trần Công Danh <congdanhqx@xxxxxxxxx> (I'm going to change my name in email setting) -- Danh