On 5/4/2020 3:13 PM, Jonathan Tan wrote: > A fuzzer running on the entry point provided by fuzz-commit-graph.c > revealed a memory leak when parse_commit_graph() creates a struct > bloom_filter_settings and then returns early due to error. Fix that > error by always freeing that struct first (if it exists) before > returning early due to error. This fuzzer is an excellent tool that I hope can continue to be extended to other features. Here is a case where it found an error in a feature long after the integration was introduced. > While making that change, I also noticed another possible memory leak - > when the BLOOMDATA chunk is provided but not BLOOMINDEXES. Also fix that > error. Thanks for discovering these issues, and for fixing them! Reviewed-by: Derrick Stolee <dstolee@xxxxxxxxxxxxx> Thanks, -Stolee
