Jeff King <peff@xxxxxxxx> writes:
> On Fri, May 01, 2020 at 04:38:48PM -0600, Taylor Blau wrote:
> ...
>> So, I propose the following:
>>
>> * We drop the idea of '--[no-]{check,verify}-oids', and always
>> silently ignore non-commit inputs, retaining the existing behavior
>> of always complaining about things that aren't valid hex OIDs, such
>> as "HEAD".
>>
>> * We always error out on missing or corrupt commit OIDs, including
>> valid OIDs that don't resolve to any object, or resolve to a tag
>> that can't be fully peeled.
>>
>> Does that seem reasonable?
>
> FWIW, I think that is the best direction. If anybody is depending on the
> "commit-graph write will complain about non-commits" behavior, they
> could only be doing so for a few versions; prior to v2.24.0 we did not.
If we had it for the past 180 days or so, that's not like " people
have seen it for only a brief time", but working it around shouldn't
be too difficult---they need to validate the input they feed to the
command themselves (or do they need to do more?).
Thanks.
