c44088ecc4 (credential: treat URL without scheme as invalid, 2020-04-18) changes the implementation for creential_from_url_gently to retun -1 if protocol is missing, but didn't update this blurb. the order of parameters used in credential_match was inconsistent between credential.c and credential.h as well, so update both to match the current implementation. Signed-off-by: Carlo Marcelo Arenas Belón <carenas@xxxxxxxxx> --- credential.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/credential.h b/credential.h index d99ec42b2a..c0e17e3554 100644 --- a/credential.h +++ b/credential.h @@ -177,8 +177,8 @@ void credential_write(const struct credential *, FILE *); * Parse a url into a credential struct, replacing any existing contents. * * If the url can't be parsed (e.g., a missing "proto://" component), the - * resulting credential will be empty but we'll still return success from the - * "gently" form. + * resulting credential will be empty and the function will return an + * error (even in the "gently" form). * * If we encounter a component which cannot be represented as a credential * value (e.g., because it contains a newline), the "gently" form will return @@ -189,7 +189,7 @@ void credential_write(const struct credential *, FILE *); void credential_from_url(struct credential *, const char *url); int credential_from_url_gently(struct credential *, const char *url, int quiet); -int credential_match(const struct credential *have, - const struct credential *want); +int credential_match(const struct credential *want, + const struct credential *have); #endif /* CREDENTIAL_H */ -- 2.26.2.686.gfaf46a9ccd
