douglas.fuller@xxxxxxxxx writes:
> Unquoted semicolons are considered shell argument separators, quote
> them so the example works correctly.
I think what you wanted to do might make sense, but the above
justification is totally incorrect.
> # or you can specify your own shell snippet
> -!f() { echo "password=`cat $HOME/.secret`"; }; f
> +"!f() { echo password=`cat $HOME/.secret`; }; f"
This is one of the examples shown, each shows possible value that
can be given to credential.helper variable. Reproducing them fully:
# run "git credential-foo"
foo
# same as above, but pass an argument to the helper
foo --bar=baz
# the arguments are parsed by the shell, so use shell
# quoting if necessary
foo --bar="whitespace arg"
# you can also use an absolute path, which will not use the git wrapper
/path/to/my/helper --with-arguments
# or you can specify your own shell snippet
!f() { echo "password=`cat $HOME/.secret`"; }; f
These are examples of values, and how they may have to be quoted in
various environments is not discussed here.
We will not want a patch that says that the second example is wrong
because "spaces separate arguments in shell and a string with a
space in it must be quoted", i.e.
$ git -c credential.helper="foo --bar=baz" frotz
and does this
# same as above, but pass an argument to the helper
-foo --bar=baz
+"foo --bar=baz"
because the quoting convention would be different depending on where
it appears. In a .git/config file, i.e.
[credential]
helper = foo --bar=baz
is perfectly fine without quoting.
$ git -c credential.helper='!f() { echo "password=`cat ...`"; }; f' frotz
would be how you would pass a one-shot config from shell.
Now, the reason why I said what you did is correct but the
justification is wrong is because the semicolon does pose a problem
in the .git/config file. In fact
[credential]
helper = !f() { echo "password=`cat ...`"; }; f
would *NOT* work, because semicolon introduces a comment in the
configuration file.
For this particular case, you can just do
[credential]
helper = !echo password=`cat $HOME/.secret`
without any quoting issues, though.
Having said all that, I think we should clarify what these sample
strings are in the introductory text in the examples.
I've always thought that they are illustrating possible values and
how to express that value in the context the values appear in is up
to the readers who learn what values to write in this document (and
they learn from manual for shell to learn the shell quoting
convention and manual for 'git config' to learn the config quoting
convention). Hence my initial reaction to your patch was "shell?
Quoting for shell is outside the scope of the explanation here".
On the other hand, for anybody who assumes that these examples are
literally showing what you write after "[credential] helper = " in
the configuration file, the example clearly is wrong and dq may be
needed (but yours is also wrong, in that it loses double quotes
around the argument to echo; if ~/.secret file had a tab in it, the
helper will now yield a wrong password and you won't be able to log
in).
