On Thu, Apr 30, 2020 at 1:22 PM Derrick Stolee <stolee@xxxxxxxxx> wrote: > > Hello, > > Here is today's test coverage report. > > It appears that _all_ of the reftable code shows up in this report as > untested. Perhaps that is the state of the world right now, or perhaps > I need to initialize a GIT_TEST_ environment variable to ensure it runs? > In either way, do we have any test coverage of that massive contribution? > Please take a look at the online report [1] for that part of the report, > as I snipped it out of this email. (again in plain text) The reftable code is currently exercised in a small way by t0031-reftable.sh The upstream library has unittests, see https://cs.bazel.build/search?q=r%3Areftable+f%3A_test.c&num=0, but I believe Git doesn't do unittests? I'll try to generate a coverage report for them. You can set GIT_TEST_REFTABLE to see coverage for reftable, but I'm not sure how useful it is given that ~15% of the tests fail. -- Han-Wen Nienhuys - Google Munich I work 80%. Don't expect answers from me on Fridays. -- Google Germany GmbH, Erika-Mann-Strasse 33, 80636 Munich Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Geschäftsführer: Paul Manicle, Halimah DeLaine Prado