Carlo Marcelo Arenas Belón <carenas@xxxxxxxxx> writes:
>> > + if (!credential_from_url_gently(&entry, line.buf, 1) &&
>> > + entry.username && entry.password &&
>> > credential_match(c, &entry)) {
>> > found_credential = 1;
>> > if (match_cb) {
>>
>> Hmph, so the idea is, instead of ignoring the potential error
>> detected by credential_from_url() and using credential when it is
>> available, we loudly attempt to parse and give warning on malformed
>> entries when we discard a line?
>
> the idea was to silently ignore the line (notice quiet = 1), which
Ah, sorry, I apparently did not read the patch carefully enough.
Thanks for a correction.
