Jonathan Tan <jonathantanmy@xxxxxxxxxx> writes: >> not about this patch: can these return values from process_acks be made >> into an enum with named enumerators? That would make what's happening >> in the call site more obvious. > > That sounds reasonable to me. > >> > + cp trace /tmp/x && >> >> Leftover debugging line? > > Ah, yes. If Junio can't or won't do it locally then I'll send out > another set with this changed. Well, if I am expecting the "named enumerators" patch anyway, I'd wait the fix to be done at the source ;-)
