Hi,
On Thu, 2 Aug 2007, Alex Riesen wrote:
>@@ -209,7 +209,8 @@ const char *set_work_tree(const char *dir)
> len = strlen(dir);
> if (len > postfix_len && !strcmp(dir + len - postfix_len,
> "/" DEFAULT_GIT_DIR_ENVIRONMENT)) {
>- strncpy(dir_buffer, dir, len - postfix_len);
>+ strncpy(dir_buffer, dir, len - postfix_len);
>+ dir_buffer[len - postfix_len] = '\0';
>
> /* are we inside the default work tree? */
> rel = get_relative_cwd(buffer, sizeof(buffer), dir_buffer);
Darn, darn, darn. strncpy does _not_ NUL terminate. I keep forgetting
that.
Better use strlcpy()?
Ciao,
Dscho
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
