Re: [PATCH v2] git-credential-store: skip empty lines and comments from store

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Apr 27, 2020 at 10:47:02AM -0700, Junio C Hamano wrote:

> Jeff King <peff@xxxxxxxx> writes:
> 
> > Those were never supposed to work. I'm mildly surprised that they did.
> 
> I know that feeling X-<.  It probably was a mistake to pretend that
> the file were editable with an editor, but it is too late to fix
> that.

I guess it is somewhat my fault for documenting the format at all
git-credential-store.txt. I probably should have said "this is a black
box and is subject to change".

> The next complainer may say that "; comment" no longer works.  We
> probably should draw a line somewhere, but I am not sure where.

If we get a bug report for "credential-store does not respect
core.commentChar" I think my head would explode. :)

-Peff



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux