On 27/04/2020 15:22, Đoàn Trần Công Danh wrote:
> Change in v3 from v2:
> * rewrite [2/4] based on Ramsay's suggestion
Yep, these all look good to me. Thanks!
ATB,
Ramsay Jones
>
> Change in v2 from v1:
> * = { 0 } is an idiom to zero the structure, it shouldn't be changed
> * change in [4/4] for prototype
> * ignore diffent function prototype
>
>
> Đoàn Trần Công Danh (4):
> test-parse-pathspec-file.c: s/0/NULL/ for pointer type
> compat/regex: move stdlib.h up in inclusion chain
> graph.c: limit linkage of internal variable
> progress.c: silence cgcc suggestion about internal linkage
>
> compat/regex/regex.c | 1 +
> compat/regex/regex_internal.h | 1 -
> graph.c | 2 +-
> progress.c | 2 +-
> progress.h | 8 ++++++++
> t/helper/test-parse-pathspec-file.c | 6 +++---
> t/helper/test-progress.c | 9 +--------
> 7 files changed, 15 insertions(+), 14 deletions(-)
>
> Range-diff against v2:
> 1: c9a1812abf = 1: c9a1812abf test-parse-pathspec-file.c: s/0/NULL/ for pointer type
> 2: 290ba923b5 < -: ---------- compat/regex: include alloca.h before undef it
> -: ---------- > 2: 8d18c53bc8 compat/regex: move stdlib.h up in inclusion chain
> 3: 39f8d85c2f = 3: 4e7580e1d1 graph.c: limit linkage of internal variable
> 4: 41eecf18ed = 4: d66d9aa677 progress.c: silence cgcc suggestion about internal linkage
>
