On 4/24/2020 4:02 PM, Junio C Hamano wrote: > Derrick Stolee <stolee@xxxxxxxxx> writes: > >> From: Derrick Stolee <dstolee@xxxxxxxxxxxxx> >> Date: Fri, 24 Apr 2020 13:11:13 +0000 >> Subject: [PATCH] multi-pack-index: close file descriptor after mmap >> >> We recently discovered that the commit-graph was not closing its >> file descriptor after memory-mapping the file contents. After this >> mmap() succeeds, there is no need to keep the file descriptor open. >> In fact, there is signficant reason to close it so we do not run >> out of descriptors. > > The above is sufficient a justification. Let's leave the remaining > two paragraphs under three-dashes. Works for me! I also thought there were too many first-person pronouns, but erred on the side of reporting "how did we figure out this was an issue?" in the message. -Stolee
