Hi Sibi, On 24/04/2020 21:29, Sibi Siddharthan wrote: > Hi Philip, > > On Fri, Apr 24, 2020 at 11:09 PM Philip Oakley <philipoakley@iee.email> wrote: >> Hi Sibi, >> >> On 24/04/2020 05:01, Sibi Siddharthan via GitGitGadget wrote: >>> From: Sibi Siddharthan <sibisiddharthan.github@xxxxxxxxx> >>> >>> This patch facilitates building git on Windows with CMake using MinGW >>> >>> NOTE: The funtions unsetenv and hstrerror are not checked in Windows >>> builds. >>> Reasons >>> NO_UNSETENV is not compatible with Windows builds. >>> lines 262-264 compat/mingw.h >>> >>> compat/mingw.h(line 25) provides a definition of hstrerror which >>> conflicts with the definition provided in >>> git-compat-util.h(lines 733-736). >>> >>> To use CMake on Windows with MinGW do this: >>> cmake `relative-path-to-srcdir` -G "MinGW Makefiles" >>> >>> Signed-off-by: Sibi Siddharthan <sibisiddharthan.github@xxxxxxxxx> >>> --- >>> CMakeLists.txt | 120 +++++++++++++++++++++++++++++++++++++++---------- >>> 1 file changed, 97 insertions(+), 23 deletions(-) >>> >>> diff --git a/CMakeLists.txt b/CMakeLists.txt >>> index 29a23eb11f7..d9eb1060390 100644 >>> [snip..] >>> find_program(SH_EXE sh) >>> +if(NOT SH_EXE) >>> + message(FATAL_ERROR "sh interpreter was not found in your path, please install one. On Windows you can get it from here https://gitforwindows.org/";) >> Either the error message or the web page it points to need to coordinate >> on the 'sh interpreter' reference to help the script kiddies follow the >> thread. At the moment there is no 'interp..' on the gitforwindows web >> page. Would someone attempting to use cmake need to use the Download or >> the Contribute buttons, or some other route to acquire the missing SH_EXE? >> > On Windows, if you are using Git Bash, then you don't have a problem. > This message was for people trying to Git on Windows without a bash shell. > > I can rephrase the message saying > "On Windows go to https://gitforwindows.org/ and download the Git > installer which ships with a sh interpreter(bash)." > > Would you suggest something else? Filling the message out a little, I'm thinking of: "sh: shell interpreter was not found in your path, please install one. On Windows, you can get it as part of 'Git for Windows' install at https://gitforwindows.org/"; The second 'install' could be dropped, but may be needed to fully qualify the instructions for some readers. The key feature I was checking was the clarity of the 'install' action, as opposed to the way sh is integrated within Git for Windows (which is a whole new topic of conversation for some users!) > >> (this is also a context line in the next patch) >> [snip..] -- Philip
