Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes: > Hi Junio, > > On Fri, 24 Apr 2020, Junio C Hamano wrote: > >> "Johannes Schindelin via GitGitGadget" <gitgitgadget@xxxxxxxxx> >> writes: >> >> > However, our GitHub workflow does not trigger on tags, therefore, this >> > logic results in a missing build for that revision. >> >> Thanks for noticing. The arrangement we had, which essentially said >> "we know we will always build tagged version, so a push of a branch >> that happens to have a tagged version at the tip can be ignored", >> served us wonderfully. Now the maintainers of projects (not just >> this one) are forbidden from tagging the tip of master, queue >> something else on top and push the result out, as it won't build or >> test the tagged version, which is a bit sad. > > Nobody forbids this... ;-) > > And I was wrong, our current GitHub workflow _is_ triggered by tags. See > e.g. https://github.com/git-for-windows/git/actions/runs/83103626 which > was triggered by v2.26.2.windows.1. > > However, you also see that it failed due to the reason I described in the > commit message. > > I guess that we should either go with this patch (which would trigger full > runs also on tags), or we could alternatively trigger only on branch > pushes (and not tag pushes)? Hmph, even if we were to go with this patch (which should be safer), we'd definitely need an updated log message, then. Thanks for double-checking.
