Re: [PATCH] credential: remove unnecessary forward declarations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Carlo Marcelo Arenas Belón  <carenas@xxxxxxxxx> writes:

> 46fd7b3900 (credential: allow wildcard patterns when matching config,
> 2020-02-20) introduced a forward declaration for credential_describe()
> that wasn't needed as well as a forward declaration for a similar
> function that was implemented a few lines below.
>
> remove the unnecessary forward declarations by moving the function
> to where it is needed instead.
>
> Signed-off-by: Carlo Marcelo Arenas Belón <carenas@xxxxxxxxx>
> ---
>  credential.c | 37 +++++++++++++++++--------------------
>  1 file changed, 17 insertions(+), 20 deletions(-)

I would rather not to see this kind of code churn for "this way it
is cleaner" (as opposed to "this is broken and needs fixing") in the
area of code that were _very_ actively touched and across _wide_
range of versions.  Maybe long after the dust from 2.17.4 and
friends settles, but not now.

Thanks.




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux