On Thu, Apr 23, 2020 at 06:14:36PM -0400, Garima Singh wrote: > > On 4/23/2020 4:58 PM, Jeff King wrote: > > These are just a few bits I noticed in the test-tool helper when the > > topic hit next (my -Wunused-parameter patch complained that we never > > looked at argc). > > > > [1/2]: test-bloom: fix some whitespace issues > > [2/2]: test-bloom: check that we have expected arguments > > > > t/helper/test-bloom.c | 28 ++++++++++++++++++++-------- > > 1 file changed, 20 insertions(+), 8 deletions(-) > > > > -Peff > > > > Thank you for doing this! > Both patches look good to me. > I also don't care about the brace/no-brace thing that > Taylor brought up for 1/2. To be clear, I don't care about them either ;). Maybe it's time that we relax that rule (if it seems that a good number of us don't mind it either way)..? > Cheers! > Garima Singh Thanks, Taylor
