Matthias Lederhofer <matled@xxxxxxx> writes: > David Kastrup <dak@xxxxxxx> wrote: >> a) Using system and shell-quoting the filename. Advantage: one can >> set EDITOR='"/home/dak/My Programs/editor"' and have it work. >> Disadvantage: shell-quoting a file name seems shell- and >> system-dependent. Actually I was talking C here, and the editor is never called from C in git but rather from the shell. So this problem is a non-problem for us. > What about this instead of quoting the argument? > > sh -c '$EDITOR "$1" "$2"' editor +5 /path/to/file > > (i.e. for C execvp("/bin/sh", "-c", "$EDITOR \"$1\" \"$2\"", "editor", > "+5", "/path/to/file")) It suffers from the fault that it does not work as far as I can see. -c does not set the positional parameters. -- David Kastrup - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html