On Fri, Apr 24, 2020 at 01:58:51AM +0100, Ramsay Jones wrote: > > +extern int progress_testing; /* to silence sparse: internal linkage */ > > int progress_testing; > > +extern uint64_t progress_test_ns; /* to silence sparse: internal linkage */ > > uint64_t progress_test_ns = 0; > > void progress_test_force_update(void); /* To silence -Wmissing-prototypes */ > > void progress_test_force_update(void) > > My preference would be to add these extern declarations to the > progress.h header file, with a note that they are only used by > the 't/helper/test-progress.c' test helper. (Also, remove the > extern declarations from test-progress.c, of course). I came here to say the same thing. As a bonus, it would catch any changes to the types in the future (rather than just segfaulting when test-progress.c attempts to use an out-of-date type). -Peff
