David Kastrup <dak@xxxxxxx> writes: > Junio C Hamano <gitster@xxxxxxxxx> writes: > >> Junio C Hamano <gitster@xxxxxxxxx> writes: >> >>> It is not just "won't apply". What if GIT_DIR had spaces (which >>> is fine) and single-quotes in it? Wouldn't it percolate down to >>> $@ because it becomes the leading directory of the temporary >>> file name? And you quote '"$@"' and eval it, now what happens? >> >> Ah, I spoke too fast. It is fine --- the shell that actually is >> doing the eval then interpolates "$@". Clever. > > Since eval folds all its arguments into a single string separated by > single blanks, actual blanks (which can be multiple or interspersed > with newlines) must not yet be seen. The string '"$@"' contains no > blanks and thus gets through unmolested. Yup. I just misread the code. Thanks, applied. - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
