On 4/20/2020 4:54 AM, Denton Liu wrote: > The overall scope of these patches is to replace inappropriate uses of > test_must_fail. IOW, we should only allow test_must_fail to run on `git` > and `test-tool`. Ultimately, we will conclude by making test_must_fail > error out on non-git commands. An advance view of the final series can > be found here[1]. I appreciate your efforts here to use best-practices throughout the test suite. Too often I look at a test script as an example on which to base a new test, but then I just repeat a bad pattern. This series looks good to me. Thanks, -Stolee
