Re: [PATCH v12 3/7] receive-pack: add new proc-receive hook

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Junio C Hamano <gitster@xxxxxxxxx> 于2020年4月15日周三 下午11:48写道:
>
> Jiang Xin <worldhello.net@xxxxxxxxx> writes:
>
> > diff --git a/builtin/receive-pack.c b/builtin/receive-pack.c
> > index 2cc18bbffd..fbbb01135e 100644
> > --- a/builtin/receive-pack.c
> > +++ b/builtin/receive-pack.c
> > @@ -13,6 +13,7 @@
> >  #include "remote.h"
> >  #include "connect.h"
> >  #include "string-list.h"
> > +#include "string.h"
> >  #include "sha1-array.h"
> >  #include "connected.h"
> >  #include "argv-array.h"
>
> What are you using from the system <string.h>, that is not covered
> by existing inclusion of "git-compat-util.h"?
>
> Don't include any system header directly in our *.c code (unless it
> is a platform-specific compat/ thing).

Will correct it.

What I am working on for reroll v13:

* Add new commit "receive-pack: feed extended_status to post-receive“

   When commands are fed to the "post-receive" hook, `extended_status` will
   be parsed and the real old-oid, new-oid, reference name will feed to
   the "post-receive" hook.

* Add test cases for "git push --porcelain".

   I found some changes not covered by test.  So I decide add some
   test cases for "git push --porcelain".  I will split the test cases into
   multiple files inside "t5411/" like:

       t5411/test-0000-normal-push.sh
       t5411/test-0001-normal-push--porcelain.sh

* Other minor fixes.




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux