Lukas Pupka-Lipinski <lukas.pupkalipinski@xxxxxxxxxxx> wrote: Sorry for the long delay, had other stuff to deal with. (and off-list replies with HTML doesn't take high priority) > Am 30.03.2020 um 01:24 schrieb Eric Wong: > > > Am 25.03.2020 um 21:38 schrieb Eric Wong: > > > > > 2.25.1.windows.1 > > > > I'm not sure how git-config or chomp() behaves on Windows systems > > > > with CRLF line endings, though. > > > > > > > > A possibility would be replacing chomp(@v) with: > > > > > > > > s/\r?\n\z//s for @v; > > > Yes that has to be done. Its implemented in > > > > > > + $v =~ s/[\x0A\x0D]//g if (defined $v); > > Does that mean you'll send a v2 of the patch which uses > > > > s/\r?\n\z//s for @v; > > > > ? > > Its already in the patch. Line > > + $v =~ s/[\x0A\x0D]//g if (defined $v); Please reread my original message about how `$v' as a scalar is incorrect (and thus your s///g): https://lore.kernel.org/git/20200325203823.GA21913@dcvr/ The correct operations are on `@v' as an array, `$v' as a scalar. Thanks.
