On Fri, Apr 10, 2020 at 11:27:50AM +0000, Johannes Schindelin via GitGitGadget wrote: > diff --git a/prompt.h b/prompt.h > index e04cced030c..e294e93541c 100644 > --- a/prompt.h > +++ b/prompt.h > @@ -6,4 +6,6 @@ > > char *git_prompt(const char *prompt, int flags); > > +int git_read_line_interactively(struct strbuf *line); > + It might be worth adding some comments discussing why one would use git_prompt() versus git_read_line_interactively(). Other than that, both patches look good to me. Thanks for calling out the changed trimming behavior preemptively. I agree it should not be a big deal either way. -Peff
