Re: [PATCH] pack-format: document missing fields

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2020-04-09 14:31:32-0700, Junio C Hamano <gitster@xxxxxxxxx> wrote:
> "Alba Mendez via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes:
> 
> >       4-byte version number (network byte order):
> > -	 Git currently accepts version number 2 or 3 but
> > +         Git currently accepts version number 2 or 3 but
> >           generates version 2 only.
> 
> Hmph, what is this hunk about?

The original line is "<TAB><SPACE>Git", she changed to 9 <SPACE>
to match with other lines.
I guess she set tabstop=4, this paragraph will be mis-aligned on that.

> > -     (undeltified representation)
> > -     n-byte type and length (3-bit type, (n-1)*7+4-bit length)
> > -     compressed data
> > -
> > -     (deltified representation)
> > -     n-byte type and length (3-bit type, (n-1)*7+4-bit length)
> > -     20-byte base object name if OBJ_REF_DELTA or a negative relative
> > -	 offset from the delta object's position in the pack if this
> > -	 is an OBJ_OFS_DELTA object

Alba, if you gonna change the above <TAB> to 8 <SPACE> above, you may
want to change here, too.
This paragraph was written with tabstop=4 in mind.
And it's in the context of below hunk.

I'm not sure if changing <TAB> to 8 <SPACE> was expected in this
file because <TAB> and <SPACE> is also mixed in "Pack file entry"
section.

-- 
Danh



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux