On Thu, 9 Apr 2020 at 16:14, Jeff King <peff@xxxxxxxx> wrote: > > On Thu, Apr 09, 2020 at 12:35:41PM +0200, Martin Ågren wrote: > > > Not sure how I managed to botch this in 1925fe0c8a. > > I managed to botch the review, as well. :) :) > I checked it with doc-diff, but was surprised to find no change. That's > because the manpage shows it the same either way (the indented chunk is > just a different example, but two examples back to back render the same > as a single one). But you can see the difference in the HTML version, > where the final example isn't in the grey box. Ah, you're using AsciiDoc. With Asciidoctor, there is a change in indentation of the "path = foo.inc" line with this new, proposed patch. The original commit reduced the number of occurrences of such AsciiDoc/tor differences around this spot, but failed to bring the number all the way down to zero. Now, finally, that discrepancy will be fixed. > That explains why I didn't see the issue when running doc-diff on the > original bug. I wonder if we could teach doc-diff to look at the HTML, > too. I'm not sure how, though. Certainly html2text or similar would get > us something diff-able, but without the visual elements (like the grey > box), I don't know that it's much more valuable than the manpages. At one point I considered trying out diffoscope for this. It should allegedly be good at comparing "everything". But being good at everything, it wanted to pull in a discouragingly large number of dependencies, so I never actually tried it out. It doesn't explicitly claim to know html or manpages (but does mention xml and pdf), so I dunno. Martin
