On Wed, 8 Apr 2020 at 17:51, Derrick Stolee <stolee@xxxxxxxxx> wrote: > > On 4/6/2020 12:59 PM, Garima Singh via GitGitGadget wrote: > > Hey! > > > > The commit graph feature brought in a lot of performance improvements across > > multiple commands. However, file based history continues to be a performance > > pain point, especially in large repositories. > > > > Adopting changed path Bloom filters has been discussed on the list before, > > and a prototype version was worked on by SZEDER Gábor, Jonathan Tan and Dr. > > Derrick Stolee [1]. This series is based on Dr. Stolee's proof of concept in > > [2] > > > > With the changes in this series, git users will be able to choose to write > > Bloom filters to the commit-graph using the following command: > > > > 'git commit-graph write --changed-paths' > > > > Subsequent 'git log -- path' commands will use these computed Bloom filters > > to decided which commits are worth exploring further to produce the history > > of the provided path. > > I noticed Jakub was not CC'd on this email. Jakub: do you plan to re-review > the new version? Or are you satisfied with the resolutions to your comments? I am planning to re-review v4 of this series when I would have time, which means probably after Easter. I think if it handles endianness issues correctly, it should be ready. -- Jakub Narębski
