"Alex Riesen" <raa.lkml@xxxxxxxxx> writes:
> const char *git_committer_info(int error_on_no_name)
> {
> - return fmt_ident(getenv("GIT_COMMITTER_NAME"),
> - getenv("GIT_COMMITTER_EMAIL"),
> - getenv("GIT_COMMITTER_DATE"),
> - error_on_no_name);
> + static char *buffer;
> + if (!buffer)
> + buffer = xmalloc(FMT_IDENT_BUFSIZE);
It is not like we are aiming to run on embedded devices, I think
trying to save static memory when the function is not called
by doing things like this is not worth it. Why not just:
static char buffer[FMT_IDENT_BUFSIZE];
instead?
In any case, I'd really like to slow things down and ask
everybody to concentrate on finding and fixing bugs in what are
scheduled for 1.5.3 for a week or so.
That means the current "master".
I did not merge Johannes's work tree rationalization patch to
"master" yet (it is now part of "next"), but I would like to
have it in, as it makes the code much easier to read compared to
the work-tree changes currently in "master". Even though the
one currently in "master" does not seem to regress the normal
usage of not using GIT_WORK_TREE environment, we would be better
off if a new feature is released in a shape that is maintainable.
Other than that topic, everything on "next" will be post 1.5.3.
Please.
I'd like to do -rc4 this weekend, and then 1.5.3 final by mid
August at the latest, but hopefully sooner.
As to parts of the system that other people are primarily in
charge of, git-gui 0.8.0 is already in as promised, updates to
gitk were merged, and we've had a nice set of improvements from
Jakub on gitweb already. Bruce seems to have a beginning of the
user manual reorganization, but I am getting the feeling it is
not ready yet.
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
