On 4/5/2020 11:14 AM, Phillip Wood wrote:
> Hi Stolee
>
> On 03/04/2020 21:48, Derrick Stolee via GitGitGadget wrote:
>> From: Derrick Stolee <dstolee@xxxxxxxxxxxxx>
>> RFC QUESTIONS:
>>
>> 1. One downside of the refs/hidden pattern is that 'git log' will
>> decorate commits with twice as many refs if they appear at a
>> remote ref (<remote>/<ref> _and_ refs/hidden/<remote>/<ref>). Is
>> there an easy way to exclude a refspace from decorations? Should
>> we make refs/hidden/* a "special" refspace that is excluded from
>> decorations?
>
> Having some way to specify which refs outside of refs/{heads,remote,tags}/ to show or exclude from decorations would be useful I think. Fetching to a hidden ref is a good idea (as are the other steps you outline above) but as you say we don't want it to show up in the output of 'git log' etc.
I'll work on this first. It seems less controversial.
>> +static int fill_remotes(struct string_list *remotes)
>
> Isn't there a easy way to get this using the config api rather than forking 'git remote'?
You're right. I should have used the config here. I've been overly
biased to how we do it in the C# layer of Scalar _plus_ how I wanted
the job-runner to run "outside" a Git repository. This could be much
simpler with the config API.
Thanks,
-Stolee
