We currently check whether a file exists and return early before reading
the file. Instead of accessing the file twice, always read the file and
check `errno` to see if the file doesn't exist.
Signed-off-by: Denton Liu <liu.denton@xxxxxxxxx>
---
sequencer.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/sequencer.c b/sequencer.c
index 09ca68f540..6e63224c41 100644
--- a/sequencer.c
+++ b/sequencer.c
@@ -431,13 +431,10 @@ static int write_message(const void *buf, size_t len, const char *filename,
static int read_oneliner(struct strbuf *buf,
const char *path, int skip_if_empty)
{
-
- if (!file_exists(path))
- return 0;
-
strbuf_reset(buf);
if (strbuf_read_file(buf, path, 0) < 0) {
- warning_errno(_("could not read '%s'"), path);
+ if (errno != ENOENT && errno != ENOTDIR)
+ warning_errno(_("could not read '%s'"), path);
return 0;
}
--
2.26.0.159.g23e2136ad0
