I apologize. I did not notice that my patch was merged. Regards, Shourya Shukla On Fri, Apr 3, 2020 at 5:50 AM Junio C Hamano <gitster@xxxxxxxxx> wrote: > > Shourya Shukla <shouryashukla.oo@xxxxxxxxx> writes: > > > Subcommands in 'submodule--helper.c' which give a callback to other functions > > have structures and macros named in the format: 'subcommand_cb' and 'SUBCOMMAND_CB_INIT' > > respectively. > > > > The subcommand 'foreach' did not follow this convention and therefore had the naming of > > the form: 'struct foreach_cb' and 'CB_FOREACH_INIT'. Rename these to: 'struct foreach_cb' > > and 'FOREACH_CB_INIT' respectively. > > > > > > Shourya Shukla (1): > > submodule--helper.c: Rename 'cb_foreach' to 'foreach_cb' > > > > builtin/submodule--helper.c | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > Isn't this already in 'master'? >
