On 4/1/2020 3:49 PM, Junio C Hamano wrote: > "Derrick Stolee via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes: > >> diff --git a/t/t5324-split-commit-graph.sh b/t/t5324-split-commit-graph.sh >> index 53b2e6b4555..4e4efcaff22 100755 >> --- a/t/t5324-split-commit-graph.sh >> +++ b/t/t5324-split-commit-graph.sh >> @@ -210,8 +210,10 @@ test_expect_success 'test merge stragety constants' ' >> git config core.commitGraph true && >> test_line_count = 2 $graphdir/commit-graph-chain && >> test_commit 15 && >> - git commit-graph write --reachable --split --size-multiple=10 --expire-time=1980-01-01 && >> + touch -m -t 201801010000.00 $graphdir/extra.graph && > > We have "test-tool chmtime" since 17e48368 (Add test-chmtime: a > utility to change mtime on files, 2007-02-24) and refrained from > using "touch -t" anywhere in our tests. Can we use it here, too? I will definitely do the more portable thing here. > Especially with its "relative" form, can't we make the test to > stay correct not just for 40 years but forever ;-)? I should clarify: the test won't break in 40 years. It will "fail to notice the bug" that was previously present. But the relative form is likely to continue catching this bug. Thanks, -Stolee
