Re: [PATCH] MyFirstObjectWalk: remove unnecessary conditional statement

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Emily Shaffer <emilyshaffer@xxxxxxxxxx> writes:

> On Sat, Mar 28, 2020 at 03:19:13PM +0000, Johannes Schindelin via GitGitGadget wrote:
>> From: Johannes Schindelin <johannes.schindelin@xxxxxx>
>> 
>> In the given example, `commit` cannot be `NULL` (because this is the
>> loop condition: if it was `NULL`, the loop body would not be entered at
>> all). It took this developer a moment or two to see that this is
>> therefore dead code.
>
> Nice catch. Thanks.
>
>> 
>> Let's remove it, to avoid puzzling future readers.
>> 
>> Signed-off-by: Johannes Schindelin <johannes.schindelin@xxxxxx>
>
> Reviewed-by: Emily Shaffer <emilyshaffer@xxxxxxxxxx>

Thanks, both.



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux