On Sat, Mar 28, 2020 at 7:49 PM Junio C Hamano <gitster@xxxxxxxxx> wrote: > Over time, we added the support to our test framework to make it > easy to leave a test early with failure, but it was not clearly > documented in t/README to help developers writing new tests. > > Signed-off-by: Junio C Hamano <gitster@xxxxxxxxx> > --- > diff --git a/t/README b/t/README > @@ -550,6 +550,40 @@ Here are the "do's:" > + test_expect_success 'test three things' ' > + for i in one two three > + do > + test_something "$i" > + done && > + test_something_else > + ' > + > + Because the status of the loop itself is the exit status of the > + test_something in the last round, the loop does not fail when > + "test_something" for "one" or "two". This is not what you want. s/"two"/& fails/