Jeff King <peff@xxxxxxxx> writes: > On Thu, Mar 26, 2020 at 03:35:23PM +0000, Johannes Schindelin via GitGitGadget wrote: > >> Changes since v2: >> >> * Reordered 4/5 before 3/5, as I had intended originally. >> >> >> * Renamed _trace_level to have a trailing underscore, in line with the >> surrounding code. >> >> >> * Added a note to the commit message why only lib-gpg.sh loses its >> hash-bang line, and no other files in t/. > > Thanks, this version looks fine to me. I left a few other comments > regarding exit/return in the other part of the thread, but frankly all > of it is too arcane and insignificant to spend more brain cycles going > back and forth on. So if I convinced/inspired you on that point, feel > free to switch it, but otherwise I'm happy with this iteration. Likewise. I agree the above three bullet points are strict improvements compared to the previous iteration.
