Jonathan Tan <jonathantanmy@xxxxxxxxxx> writes: >> New in V2: changed parameter name, used Taylor's commit message >> suggestions, and used Elijah's documentation suggestions. > > I think the discussion has shifted away from whether this functionality > is desirable (or desirable and we should implement this functionality > without any CLI option) to the name and nature of the CLI option. Before > I send out a new version, what do you think of using this name and > documenting it this way: > > --keep-cherry-pick=(always|never):: > ... > The default is 'never'. > + > See also INCOMPATIBLE OPTIONS below. Sounds much better to me. I do not mind --[no-]keep-cherry-pick, either, by the way. I know I raised the possibility of having to make it non-bool later, but since then I haven't thought of a good third option myself anyway, so... Thanks for keeping the ball rolling.
