Hi Peff, On Thu, 26 Mar 2020, Jeff King wrote: > On Wed, Mar 25, 2020 at 05:41:21AM +0000, Johannes Schindelin via GitGitGadget wrote: > > > Let's fix this by no longer redirecting the output not to `/dev/null`. > > This is now possible because the affected prereqs were turned into lazy > > ones (and are therefore evaluated via `test_eval_` which respects the > > `--verbose` option). > > > > Note that we _still_ redirect `stdout` to `/dev/null` for those commands > > that sign their `stdin`, as the output would be binary (and useless > > anyway, because the reader would not have anything against which to > > compare the output). > > This looks good. You could drop the redirection of stdin in one case, > too (since test_eval_ already does so) but I don't mind leaving it as > documentation. I considered that, but decided that I'd rather save myself the brain cycles in the future when reading that code (I would ask myself "*what* is signed here?"). That's why I left the `</dev/null` in. Also, I could imagine that there might be some unexpected interaction with `GIT_DEBUGGER` if I removed that `</dev/null`, and I'd just like to stay on the safe side here. Ciao, Dscho
