On 24/03/20 1:01 am, Christian Couder wrote: >> So shouldn't the test file itself have mentioned (say as a comment at >> the top >> or in a separate README) that it was expecting subversion 1.8 or lesser on >> the system? I am using Ubuntu 18.04 and by default the package manager >> installs subversion 1.9. > It would be better if the test could be fixed to work with subversion > 1.9. Otherwise the test could perhaps check the subversion version and > run only if subversion is version 1.8 or lesser. Yeah that makes sense. I will try to look into how the tests can be fixed to work with svn 1.9. >> This issue might also be present in other git-svn test files. (I haven't >> checked >> though, not sure how to run just git-svn tests) > Maybe with something like: > > $ cd t > $ prove --jobs 8 t91*-svn*.sh Thanks. I ran the command and found that all tests (except t9119) fail for svn 1.9 and pass for 1.8. t9119 gives the below output for svn 1.8: skipped: skipping svn-info test (SVN version: 1.8.13 not supported) 't9119-git-svn-info.sh' seems to already have the code to check the version of subversion. So we could use the same code to check the correct version in 'lib-git-svn.sh'? Note that I haven't checked which all subversion versions work for a given test (only know that svn 1.8 works for all).
