On March 22, 2020 9:10 PM, Junio C Hamano wrote:
> The latest feature release Git v2.26.0 is now available at the usual places. It
> is comprised of 504 non-merge commits since v2.25.0, contributed by 64
> people, 12 of which are new faces.
We had t0301 fail again. This is run entirely within bash as we gave up on ksh. I need some advice on what to do here. It does look like this is actually in git rather than the tests, based on below.
What is really strange is that the subtests are transiently failing and not the same test each time. I cannot get any consistency during test runs. I also do not see anything in the differences that might account for this, unless somehow the unicode length. I did revert and retried the test, which also resulted in transient failures. It all works fine when I use -x, so I can't shed light on it from there. An example of the failure is:
--- expect-stdout 2020-03-23 20:40:57 +0000
+++ stdout 2020-03-23 20:40:58 +0000
@@ -1,4 +1,4 @@
protocol=https
host=example.com
-username=askpass-username
-password=askpass-password
+username=store-user
+password=store-pass
not ok 21 - helper (cache) can forget host
We also had a hang in subtest 23 at
expecting success of 0301.23 'helper (cache) can forget user':
check reject $HELPER <<-\EOF &&
protocol=https
host=example.com
username=user1
EOF
check fill $HELPER <<-\EOF
protocol=https
host=example.com
username=user1
--
protocol=https
host=example.com
username=user1
password=askpass-password
--
askpass: Password for 'https://user1@xxxxxxxxxxx':
EOF
++ check reject cache
++ credential_opts=
++ credential_cmd=reject
++ shift
++ for arg in "$@"
++ credential_opts=' -c credential.helper='\''cache'\'''
++ read_chunk
++ read line
++ case "$line" in
++ echo protocol=https
++ read line
++ case "$line" in
++ echo host=example.com
++ read line
++ case "$line" in
++ echo username=user1
++ read line
++ read_chunk
++ read line
++ read_chunk
++ read line
++ eval 'git -c credential.helper='\''cache'\'' credential reject <stdin >stdout 2>stderr'
+++ git -c credential.helper=cache credential reject
