On 3/20/20 5:06 PM, Josh Steadmon wrote:
Via trace2, Git can already log interesting config parameters (see the trace2_cmd_list_config() function). However, this can grant an incomplete picture because many config parameters also allow overrides via environment variables. To allow for more complete logs, we add a new trace2_cmd_list_env_vars() function and supporting implementation, modeled after the pre-existing config param logging implementation. Signed-off-by: Josh Steadmon <steadmon@xxxxxxxxxx> --- As I mentioned in the commit message, I modeled this pretty closely on the config parameter reporting code. It may make sense to split some of this out into its own file, particularly the parts in trace2/tr2_cfg.c. Alternatively, we could also just make the env var reporting part of the config param reporting. Let me know if you have a preference either way.
Looks good to me. Jeff
