Philippe Blain <levraiphilippeblain@xxxxxxxxx> writes: >> - This option can be either set to a boolean value or to 'on-demand'. >> + This option can be set either to a boolean value or to 'on-demand'. >> Setting it to a boolean changes the behavior of fetch and pull to > > I think in the context of patch 5 maybe it would be good to be > careful here, and state that this only affects the underlying > "fetch" in "pull", and not the whole pull ? Meaning that sub(sub)*modules are fetched but the merge is done only for the top-level superproject? I guess it does not hurt to spell it out. Good suggestion. >> + If not set, 'on-demand' is used by default, unless >> + 'submodule.recurse' is set. > > I know Junio seems to think otherwise, but to me it would be > clearer if this would be clearly spelled out: > > Defaults to 'on-demand', or to the value of 'submodule.recurse' if set. Well, between the above two, I'd actually have slight preference to yours, but they both look clear enough to almost the same degree, at least to me. Thanks.
