On 19-03-2020 22:12, Shourya Shukla wrote:
Hello Harshit,
Replace 'test -f' with the helper function 'test_path_is_file' as the helper function improves the code readability and also gives better error messages.
Again the same thing, you may follow what I stated before regarding commit messages.
The commit title can be of the form:
t4131: use helpers to replace test -f <path>
<<commit description>>
Just curious, isn't the commit title already like that in this patch?
The subject does read:
[GSoC][PATCH 2/2] t4131: use helper function to replace test -f <path>"
What am I missing?
--
Sivaraam
